-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement] add sklearnex version of validate_data
, _check_sample_weight
#2177
base: main
Are you sure you want to change the base?
[enhancement] add sklearnex version of validate_data
, _check_sample_weight
#2177
Conversation
/intelci: run |
/intelci: run |
Please manually check private CI, failure is a 503 http error (unrelated to the PR). |
onedal/utils/validation.py
Outdated
@@ -438,3 +443,31 @@ def _is_csr(x): | |||
return isinstance(x, sp.csr_matrix) or ( | |||
hasattr(sp, "csr_array") and isinstance(x, sp.csr_array) | |||
) | |||
|
|||
|
|||
def _assert_all_finite(X, allow_nan=False, input_name=""): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a version check required here that sets _assert_all_finite()
to the daal4py
version for older oneDAL releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made for circumstance (won't come up in any of the CIs though)
Is there any additional need to check if "old" and "new" finiteness checks produce the same results. I'd say no, because they're both tested independently, and neither is a gold standard. But let me know if you think otherwise. |
…icfaust/scikit-learn-intelex into dev/sklearnex_assert_all_finite
/intelci: run |
/intelci: run |
/intelci: run |
Description
This is another interim PR towards introducing the new onedal finiteness checker into the sklearnex estimator workflows. This is not yet introduced into any of the estimators, and so performance benchmarks are not necessary. This PR focuses on making sure that input and outputs of
validate_data
and_check_sample_weight
are respected for sycl_usm_ndarray types and that the new finite checker is properly called and yields results in a range of scenarios. This is also done to minimize the review burden, as changing all the estimators is a large change.The new process for all estimators will be as follows:
validate_data
and_check_sample_weight
once in sklearnex in_onedal_*
methods called by device_offload's dispatchvalidate_data
or_check_sample_weight
unless an operation before the oneDAL backend can yield a inf/NaN (this is a strict condition, and is expected to be extremely uncommon/ hard to allow)onedal
orsklearnex
folders must have assert_all_finite checks turned off.A follow up PR will create a design test for this, and will introduce the new validate_data in one estimator. Other estimators will occur in individual PRs due to the depth of the changes.
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance