Let the test suite install OpenSCAP packages #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
srbarrios
reviewed
Nov 23, 2020
Completly agree. Created cards: #802 and SUSE/spacewalk#13199 |
moio
reviewed
Nov 24, 2020
| - mgr-cfg-actions | ||
| - wget | ||
| - require: | ||
| - sls: default | ||
|
|
||
| {% if grains['os'] == 'SUSE' %} | ||
| {% if grains['os'] == 'SUSE' and '12' in grains['osrelease'] %} |
There was a problem hiding this comment.
Is aaa_base-extras something exclusively for SLE 12? Ie. not needed/present on SLE 15?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
The openSCAP packages were installed half in sumaform, half in the test suite, leading to a huge mess.
This situation is due to the fact that the QAM test suite does not use sumaform's
testsuitemodule. But besides this immediate reason, it has always been wrong to let sumaform prepare ulterior processings. sumaform should prepare machines as pristine as possible.This PR lets the test suite do all the job. See uyuni-project/uyuni#2880 for implementation on test suite side.