Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uyuni remove spacewalk utils extras #9454

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rjmateus
Copy link
Member

@rjmateus rjmateus commented Nov 8, 2024

What does this PR change?

remove package spacewalk-.utils-extras and change tools according to the definition at: https://confluence.suse.com/display/~RDiasMateus/SUMA+cmd+tools?focusedCommentId=1649082905#comment-1649082905

To review:

  • I move sw-ldap-user-sync to the contrib repo. Should it e the case?
  • Moved spacewalk-watch-channel-sync.sh to main package spacewalk-utils.
    related to: Port uyuni utils extra contrib#30

GUI diff

No difference.

Before:

After:

  • DONE

Documentation

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: add explanation

  • No tests: already covered

  • Unit tests were added

  • Cucumber tests were added

  • DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@rjmateus rjmateus requested a review from a team as a code owner November 8, 2024 15:44
@rjmateus rjmateus requested review from ycedres and removed request for a team November 8, 2024 15:44
@rjmateus rjmateus marked this pull request as draft November 8, 2024 15:44
admd
admd previously approved these changes Nov 28, 2024
Copy link
Contributor

@admd admd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Ricardo. Thank you.

@rjmateus rjmateus force-pushed the uyuni_remove_spacewalk-utils-extras branch from 60136d9 to 432a438 Compare December 2, 2024 17:05
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - check if you can squash some commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants