Improve debian reposync logging (bsc#1227859) #9705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since all loggers in the logging library inherit the config from their parents up to the root logger, we can use the root logger similarly to rhnLog's LOG object. The root logger singleton is changed to direct the log messages to the same log file with a similar log level as LOG.
meaksh
force-pushed
the
master-bsc1227859
branch
from
efa3ad8 to
52f4ad7
Compare
agraul
requested changes
Feb 10, 2025
Comment on lines
+430
to
+431
| # pylint: disable-next=logging-fstring-interpolation | ||
| logger.error(f"{DpkgRepo.GPG_VERIFICATION_FAILED}: {release_file}") |
There was a problem hiding this comment.
This should be equivalent and should pass the linting error (f-strings are eagerly evaluated, which is why they are discouraged in logging, since logging may never fire)
Suggested change
| # pylint: disable-next=logging-fstring-interpolation | |
| logger.error(f"{DpkgRepo.GPG_VERIFICATION_FAILED}: {release_file}") | |
| logger.error("%s: %s", DpkgRepo.GPG_VERIFICATION_FAILED, release_file) |
| @@ -309,15 +309,15 @@ def _exit(): | |||
| atexit.register(_exit) | |||
|
|
|||
|
|
|||
| def log_level_to_logging_constant(rhnLog_log_level: int): | |||
| def log_level_to_logging_constant(rhnlog_log_level: int): | |||
There was a problem hiding this comment.
rhnLog is still called rhnLog, the name was chosen on purpose to reflect that.
agraul
reviewed
Feb 10, 2025
Comment on lines
+259
to
+262
| # Apparently we need to call initCFG and have CFG available | ||
| # to prevent some errors accessing CFG later on during package | ||
| # import. | ||
| initCFG("server.satellite") |
There was a problem hiding this comment.
Can we please fix this as well? I'm okay with doing it in another PR, as we already have the patch we shouldn't leave it lying around until it does not apply anymore.
agraul
reviewed
Feb 10, 2025
There was a problem hiding this comment.
You're adding a lot of pylint disable comments. What's the plan for those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR refactors and enhances logging around debian reposync executions.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: no tests around reposync logging
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/24816
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!