Feature/2219 changelog v2 #439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
September 17, 2024 08:21
mabiede
reviewed
Oct 3, 2024
Comment on lines
+11
to
+15
| let predicate_key (key : Key.t) = | ||
| let open Key in | ||
| match key with | ||
| | CustomField id -> Custom_field.Id.value id | ||
| | Hardcoded key -> show_hardcoded key |
There was a problem hiding this comment.
Suggested change
| let predicate_key (key : Key.t) = | |
| let open Key in | |
| match key with | |
| | CustomField id -> Custom_field.Id.value id | |
| | Hardcoded key -> show_hardcoded key | |
| let predicate_key : Key.t -> string = | |
| let open Key in | |
| function | |
| | CustomField id -> Custom_field.Id.value id | |
| | Hardcoded key -> show_hardcoded key |
Comment on lines
+18
to
+22
| let yojson_of_value m = | ||
| match m with | ||
| | NoValue -> `Null | ||
| | Single single -> single |> yojson_of_single_val | ||
| | Lst values -> `List (CCList.map yojson_of_single_val values) |
There was a problem hiding this comment.
Suggested change
| let yojson_of_value m = | |
| match m with | |
| | NoValue -> `Null | |
| | Single single -> single |> yojson_of_single_val | |
| | Lst values -> `List (CCList.map yojson_of_single_val values) | |
| let yojson_of_value = function | |
| | NoValue -> `Null | |
| | Single single -> single |> yojson_of_single_val | |
| | Lst values -> `List (CCList.map yojson_of_single_val values) |
Comment on lines
+157
to
+161
| let to_int s = | ||
| s | ||
| |> CCString.replace ~which:`Left ~sub:"0" ~by:"" | ||
| |> CCInt.of_string | ||
| |> CCOption.get_exn_or error |
There was a problem hiding this comment.
Suggested change
| let to_int s = | |
| s | |
| |> CCString.replace ~which:`Left ~sub:"0" ~by:"" | |
| |> CCInt.of_string | |
| |> CCOption.get_exn_or error | |
| let to_int = | |
| CCString.replace ~which:`Left ~sub:"0" ~by:"" | |
| %> CCInt.of_string | |
| %> CCOption.get_exn_or error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.