add rps cmd && add game category #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logicguy1
added
the
Pending Changes
|
What should I change to this pull-request? (I'm sorry if it's something obvious) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This Pull-Request introduces a new command - RPS, or Rock Paper Scissors.
To try it out, it's simple:
v!rpsThen follow the instructions.
It also introduces a new game category (
prefix = None) in whichtic_tac_toe.pyandrps.pyare in.Describe the changes proposed in the pull request
Just a simple command with an additional category.
What is the current behavior?
I tested it multiple times (e.g. reacting to a different message, wrong reaction etc) and I didn't encounter any issue.
But it's still possible that some feature does not work as intended.
Does this PR introduce a breaking change?
If you're going to add a game command, please add it in the
game