Skip to content

limit TTL value range and add Dns response ttl Configuration v4 #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

limit TTL value range and add Dns response ttl Configuration v4 #3458

wants to merge 2 commits into from

Conversation

@4-FLOSS-Free-Libre-Open-Source-Software
Copy link
Contributor

@4-FLOSS-Free-Libre-Open-Source-Software 4-FLOSS-Free-Libre-Open-Source-Software commented Jul 20, 2025

  1. Backporting Response TTL Configuration from v5 to v4 fixes:
  1. limit TTL value range in handleIPQuery according RFC 1035

@dyhkwong
Copy link
Contributor

dyhkwong commented Jul 21, 2025

ResponseTtl is already a uint32. If input value is out of range it should report errors rather than silently overriding the value set by the user.

@4-FLOSS-Free-Libre-Open-Source-Software
Copy link
Contributor Author

4-FLOSS-Free-Libre-Open-Source-Software commented Jul 21, 2025

Yes makes sense.

@xiaokangwang
Copy link
Contributor

xiaokangwang commented Sep 1, 2025

I see this is still a draft. Let me know once this is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@4-FLOSS-Free-Libre-Open-Source-Software @dyhkwong @xiaokangwang