Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetricsServerExporter] Enhance probes #1036

Merged
merged 2 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions stable/metrics-server-exporter/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
apiVersion: v1
appVersion: ">=2.0.0"
version: 0.8.0
version: 0.9.0
description: K8s metrics exporter in prometheus format
name: metrics-server-exporter
home: https://iguazio.com
icon: https://www.iguazio.com/wp-content/uploads/2019/10/Iguazio-Logo.png
sources:
- https://github.com/iguazio/zapp/
maintainers:
- name: odedm
email: [email protected]
- name: sahare
email: [email protected]
- name: Iguazio
email: [email protected]
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,28 @@ spec:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
command: ["metricsserverexporter"]
args:
args:
- --log-level={{ .Values.container.logLevel }}
- --namespace={{ .Release.Namespace }}
- --listen-addr=:{{ .Values.container.port }}
- --handle-gpu-metrics={{ .Values.container.handleGPUMetrics }}
ports:
- containerPort: {{ .Values.container.port }}
- containerPort: {{ .Values.container.port }}
protocol: {{ .Values.container.protocol }}
startupProbe:
failureThreshold: {{ .Values.startupProbe.failureThreshold }}
httpGet:
path: {{ .Values.container.healthzPath }}
port: {{ .Values.container.port }}
scheme: {{ .Values.container.scheme }}
initialDelaySeconds: {{ .Values.startupProbe.initialDelaySeconds }}
periodSeconds: {{ .Values.startupProbe.periodSeconds }}
successThreshold: {{ .Values.startupProbe.successThreshold }}
timeoutSeconds: {{ .Values.startupProbe.timeoutSeconds }}
livenessProbe:
failureThreshold: {{ .Values.livenessProbe.failureThreshold }}
httpGet:
liranbg marked this conversation as resolved.
Show resolved Hide resolved
path: {{ .Values.container.path }}
path: {{ .Values.container.healthzPath }}
port: {{ .Values.container.port }}
scheme: {{ .Values.container.scheme }}
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
Expand All @@ -52,7 +62,7 @@ spec:
readinessProbe:
failureThreshold: {{ .Values.readinessProbe.failureThreshold }}
httpGet:
path: {{ .Values.container.path }}
path: {{ .Values.container.healthzPath }}
port: {{ .Values.container.port }}
scheme: {{ .Values.container.scheme }}
initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
Expand Down
43 changes: 25 additions & 18 deletions stable/metrics-server-exporter/values.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
image:
repository: iguaziodocker/metrics-server-exporter
tag: 0.1.3
repository: gcr.io/iguazio/metrics-server-exporter
tag: unstable
pullPolicy: IfNotPresent

container:
port: 8000
protocol: TCP
scheme: HTTP
path: /metrics
healthzPath: /healthz

logLevel: info

Expand All @@ -18,30 +19,36 @@ service:
protocol: TCP

livenessProbe:
failureThreshold: 3
initialDelaySeconds: 30
periodSeconds: 10
failureThreshold: 30
periodSeconds: 30
successThreshold: 1
timeoutSeconds: 30
timeoutSeconds: 60

readinessProbe:
failureThreshold: 3
initialDelaySeconds: 5
periodSeconds: 10
periodSeconds: 45
successThreshold: 1
timeoutSeconds: 30

startupProbe:
failureThreshold: 10
periodSeconds: 15
successThreshold: 1
timeoutSeconds: 10

## Deployment resources
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
# limits:
# cpu: 100m
# memory: 150Mi
# requests:
# cpu: 100m
# memory: 150Mi

# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
# limits:
# cpu: 100m
# memory: 150Mi
# requests:
# cpu: 100m
# memory: 150Mi

## Node labels for pod assignment
## Ref: https://kubernetes.io/docs/user-guide/node-selection/
Expand Down