Skip to content

Commit

Permalink
Update tests expectations that check stack traces. (#205)
Browse files Browse the repository at this point in the history
V8 has changed how Function.blah entries look like in stack traces
(see https://crrev.com/c/5907815). This CL updates tests expectations
according to new behavior and re-enables the affected tests.
  • Loading branch information
isheludko authored Nov 19, 2024
1 parent a85d658 commit f7bdc2e
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 10 deletions.
2 changes: 1 addition & 1 deletion test/message/assert_throws_stack.out
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
actual: Error: foo
at assert.throws.bar (*assert_throws_stack.js:*)
at getActual (node:assert:*)
at Function.throws (node:assert:*)
at strict.throws (node:assert:*)
at Object.<anonymous> (*assert_throws_stack.js:*:*)
at *
at *
Expand Down
2 changes: 1 addition & 1 deletion test/message/internal_assert_fail.out
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Error [ERR_INTERNAL_ASSERTION]: Unreachable!
This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
Please open an issue with this stack trace at https://github.com/nodejs/node/issues

at Function.fail (node:internal/assert:*:*)
at assert.fail (node:internal/assert:*:*)
at * (*test*message*internal_assert_fail.js:7:8)
at *
at *
Expand Down
4 changes: 0 additions & 4 deletions test/message/message.status
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ vm_display_syntax_error.js: SKIP
vm_dont_display_runtime_error.js: SKIP
vm_dont_display_syntax_error.js: SKIP

# Temporarily skip for https://crrev.com/c/5907815
assert_throws_stack.js: SKIP
internal_assert_fail.js: SKIP

[$system==win32]

[$system==linux]
Expand Down
3 changes: 0 additions & 3 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@ test-v8-serdes: SKIP

test-v8-stats: SKIP

# Temporarily skip for https://crrev.com/c/5907815
test-fs-promises: SKIP

test-strace-openat-openssl: SKIP
test-policy-dependency-conditions: SKIP

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-fs-promises.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ assert.strictEqual(
code: 'ENOENT',
name: 'Error',
message: /^ENOENT: no such file or directory, access/,
stack: /at async Function\.rejects/
stack: /at async ok\.rejects/
}
).then(common.mustCall());

Expand Down

0 comments on commit f7bdc2e

Please sign in to comment.