[fastapi] Stop using deprecated FastApiTypedArray #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the signature of `FastCopy` and `WriteString` to not use `FastApiTypedArray` anymore. Instead the buffer is received as `Local<Value>`, and the type check is done in node instead of generated code. The data of the buffers is extracted the same as for slow calls. For the source of `FastCopy` it would also be possible to use the new V8 API `ArrayBufferView::GetContents()`, but I thought it's better for now to remain close to the regular implementation. For the other buffers this API cannot be used because it does not provide write access to the data, as it copies the data if it's stored on the heap.
victorgomes
pushed a commit
that referenced
this pull request
Nov 18, 2024
* [fastapi] Stop using deprecated FastApiTypedArray * [fastapi] Stop using deprecated FastApiTypedArray This PR changes the signature of `FastCopy` and `WriteString` to not use `FastApiTypedArray` anymore. Instead the buffer is received as `Local<Value>`, and the type check is done in node instead of generated code. The data of the buffers is extracted the same as for slow calls. For the source of `FastCopy` it would also be possible to use the new V8 API `ArrayBufferView::GetContents()`, but I thought it's better for now to remain close to the regular implementation. For the other buffers this API cannot be used because it does not provide write access to the data, as it copies the data if it's stored on the heap.
victorgomes
pushed a commit
that referenced
this pull request
Dec 18, 2024
* [fastapi] Stop using deprecated FastApiTypedArray * [fastapi] Stop using deprecated FastApiTypedArray This PR changes the signature of `FastCopy` and `WriteString` to not use `FastApiTypedArray` anymore. Instead the buffer is received as `Local<Value>`, and the type check is done in node instead of generated code. The data of the buffers is extracted the same as for slow calls. For the source of `FastCopy` it would also be possible to use the new V8 API `ArrayBufferView::GetContents()`, but I thought it's better for now to remain close to the regular implementation. For the other buffers this API cannot be used because it does not provide write access to the data, as it copies the data if it's stored on the heap.
victorgomes
pushed a commit
that referenced
this pull request
Jan 20, 2025
* [fastapi] Stop using deprecated FastApiTypedArray * [fastapi] Stop using deprecated FastApiTypedArray This PR changes the signature of `FastCopy` and `WriteString` to not use `FastApiTypedArray` anymore. Instead the buffer is received as `Local<Value>`, and the type check is done in node instead of generated code. The data of the buffers is extracted the same as for slow calls. For the source of `FastCopy` it would also be possible to use the new V8 API `ArrayBufferView::GetContents()`, but I thought it's better for now to remain close to the regular implementation. For the other buffers this API cannot be used because it does not provide write access to the data, as it copies the data if it's stored on the heap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.