-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another bunch of changes #219
Conversation
@@ -16,7 +16,7 @@ | |||
%% | |||
%% Licence: GPL2+ | |||
%% | |||
\ProvidesPackage{asymptote} | |||
\ProvidesPackage{patch-asy} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No functional change, just fix a warning.
(actually why is the patch even necessary in the first place? What's the change compared to the original asymptote package?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the patched version numbers things in a way that allows for counters, so the figures get called e.g. Napkin-7A.asy rather than instead of Napkin-139.asy which is super brittle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume by "brittle" you mean that "every figure gets recompiled every time a figure gets added somewhere in the middle of the document" (I don't think something can actually break/compiles incorrectly, just that the time overhead is huge). Sound reasonable yes.
Evidently someone would have thought of it best practices - Is it better to use Asymptote in-document vs compiling separately? - TeX - LaTeX Stack Exchange (that package is only made in 2014 though) although I assume there's not much gain in refactoring code at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You assume correctly.
I haven't heard of asypictureB
before but that's good to know, maybe for future projects. Though having to run a script or enable shell-escape sounds somewhat undesirable too.
@@ -146,7 +146,7 @@ @unpublished{ref:gorin | |||
editor={Tony Zhang}, | |||
institution={MIT}, | |||
year={2018}, | |||
url={https://www.mit.edu/~txz/links.html}, | |||
url={https://web.archive.org/web/20190617235844/http://web.mit.edu/txz/www/links.html}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should fix #161. (looks like the author graduated from MIT, so the website got taken down?)
@@ -358,7 +358,7 @@ \section{The signature of a number field} | |||
\[ \frac{\Norm(\ka)}{2^{r_2}} \sqrt{\left\lvert \Delta_K \right\rvert}. \] | |||
\end{lemma} | |||
\begin{proof}[Sketch of Proof] | |||
Let \[ d = \Norm(\ka) \defeq [\OO_K : \ka]. \] | |||
Let \[ d = \Norm(\ka) \defeq |\OO_K / \ka|. \] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like I re-did these things... sorry.
|
||
Nevertheless, I hope you agree that $\ka+\kb$ is a natural notation, compared to something like $(\ka, \kb)$. | ||
|
||
Because factorization involves \emph{multiplying}, instead of adding, the ideals together, we will not need to use the notation $\ka+\kb$ any time soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(indeed, I can't find the notation being used anywhere in the following chapters)
|
||
% TODO is it true that, there exist some \alpha and integers c_2, | ||
% \dots, c_{n-1} such that \OO_K is generated by {1, \alpha, \alpha^2/c_2, | ||
% \dots, \alpha^{n-1}/c_{n-1}}? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to give some intuition. (maybe if this part is true it would give more intuition -- 𝒪_K can be "visualized" as ℤ^n, but I'm not sure)
Then $\SF$ is not a sheaf. Indeed, $s_1(x) = 0$ in $\SF((-1, 0))$ | ||
and $s_2(x) = 1$ in $\SF((0, 1))$ agrees on the (empty) overlap, | ||
but they cannot be glued together to an element in $\SF((-1, 0) \cup(0, | ||
1))$. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another misconception I had for a while. Can't help to have more red boxes.
(in a similar vein, the function f(p) = 1 if p is on x-axis, 0 if p is on y-axis is regular on D(x+y) of V(xy) ⊆ 𝔸² -- i.e. the quasiaffine scheme that is the distinguished open set of the union of x-axis and y-axis -- even though it doesn't "look" continuous. But I can't really find a good place to fit this example in...?)
I suppose it's another case where "geometric intuition works better than algebraic calculation" -- if you try hard enough you can derive an explicit expression for the function above -- namely, x/(x+y).
@@ -784,7 +815,7 @@ \section{Sheafification (optional)} | |||
\end{problem} | |||
|
|||
\begin{problem} | |||
Let $\SF$ be a sheaf on a space $X$ and let $s \in \SF(X)$ | |||
Let $\SF$ be a sheaf of rings on a space $X$ and let $s \in \SF(X)$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(can't hurt to be explicit.)
based on its intrinsic properties only, which is done by studying the collection | ||
of algebraic functions on it. | ||
|
||
In \cite{ref:vakil} ``Motivating example: The sheaf of differentiable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel a bit clumsy.
@@ -4,6 +4,7 @@ | |||
%% which is annoying... font issues | |||
\usepackage[T1]{fontenc} | |||
\usepackage{lmodern} | |||
\usepackage[pdfusetitle]{hyperref} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the warning, and actually make the pdfusetitle feature work.
\renewcommand{\mkbibnameprefix}[1]{\textsc{#1}} | ||
\renewcommand{\mkbibnameaffix}[1]{\textsc{#1}} | ||
\renewcommand{\mkbibnamesuffix}[1]{\textsc{#1}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix more warnings. (hopefully I don't accidentally break something)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should work okay, i have them this way in evan.sty as well
thanks much, appreciated |
As usual, comment on various changes will be made.