Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: implement hsv #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

new: implement hsv #24

wants to merge 4 commits into from

Conversation

JDongian
Copy link
Contributor

WIP.

@vaab
Copy link
Owner

vaab commented Jan 22, 2016

Oh my, I didn't spot these HSV false mentions in the README.rst... thank you for bringing that up.

I've read the rest of the code, and it seems there's more work to do :) . This is a very good start ! Many thanks. Don't forget to document this also in the README.rst, wherever you see hsl you can mention and show hsv examples. And is there's a direct relation between hsl and hsv don't be afraid to show it clearly thanks to a doctest example that will also add a test to this relation.
Many thanks for your work !

@vaab
Copy link
Owner

vaab commented Jan 22, 2016

You might want to read #16

@vaab vaab added this to the 1.3 milestone Jan 22, 2016
@vaab
Copy link
Owner

vaab commented Oct 18, 2016

Note: for the final PR, don't forget NOT to commit setup.cfg version information mods ;-).

Tell me when you think it is time for a thorough review on my side.

While I'm at it, note also that what I'll need is also only 1 nice commit that holds doc/tests/implementation (unless you have several features that can be clearly separated by concerns). I guess here 1 commit should be enough. This can be done after my thorough review, or I can do it myself... but then it may delay the inclusion of the code a little bit.

An exception to that if you move code around for code coherence or cosmetics consideration, please separate these in a first commit so that this is very clear that you are only moving code around and it won't create messy diffs for me to review, or for future reading of the changelog history. These commits can be before or after your implementation. (in the current state, your separated commits are a pain to review on github as-is, I need to pull your changes on my side and ask for the whole diff to have a nicer diff...)

If you have trouble using git to clean your code submission, I could do it for you also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants