Skip to content

Conversation

@vursen
Copy link

@vursen vursen commented Oct 29, 2025

  1. ParentItemProvider has been removed, as the HierarchicalDataProvider interface now officially supports the getParent method. The only difference is that it's now expected to return null if the item doesn't have a parent, instead of an Optional:

    - public Optional<Department> getParent(Department item) {
    + public Department getParent(Department item) {
  2. The scrollToItem feature has been removed from this addon, as it's now built into Vaadin's official TreeGrid component. Depending on the data provider type, it may require implementing HierarchicalDataProvider#getParent or/and HierarchicalDataProvider#getItemIndex:

    DataProvider isInMemory() getItemIndex() getParent()
    TreeDataProvider true not required not required
    HierarchicalDataProvider true not required required
    HierarchicalDataProvider false required required

    When using in-memory hierarchical data providers, getParent() is still the only required method, however.

@vursen vursen force-pushed the v25-upgrade branch 2 times, most recently from bdc7191 to b4069f5 Compare October 30, 2025 09:42
@vursen vursen force-pushed the v25-upgrade branch 3 times, most recently from c7b89c8 to 3413723 Compare October 30, 2025 09:51
@vursen vursen marked this pull request as ready for review October 30, 2025 14:50
*
* @param item the item where to scroll to
*/
public void scrollToItem(T item) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scrollToItem feature is now part of TreeGrid.

@vursen vursen requested review from web-padawan and removed request for mlopezFC October 31, 2025 07:26
Copy link

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested the demo and everything seems to work.

return '0.2.0';
}

static get lumoInjector() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could also update static get version() above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.

@vursen vursen removed the request for review from sissbruecker November 4, 2025 09:07
@TatuLund TatuLund merged commit b5530b8 into v25 Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants