-
Notifications
You must be signed in to change notification settings - Fork 8
refactor!: Upgrade to Vaadin 25 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bdc7191 to
b4069f5
Compare
c7b89c8 to
3413723
Compare
| * | ||
| * @param item the item where to scroll to | ||
| */ | ||
| public void scrollToItem(T item) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scrollToItem feature is now part of TreeGrid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested the demo and everything seems to work.
| return '0.2.0'; | ||
| } | ||
|
|
||
| static get lumoInjector() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could also update static get version() above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done.
ParentItemProviderhas been removed, as theHierarchicalDataProviderinterface now officially supports thegetParentmethod. The only difference is that it's now expected to returnnullif the item doesn't have a parent, instead of anOptional:The
scrollToItemfeature has been removed from this addon, as it's now built into Vaadin's official TreeGrid component. Depending on the data provider type, it may require implementingHierarchicalDataProvider#getParentor/andHierarchicalDataProvider#getItemIndex:When using in-memory hierarchical data providers,
getParent()is still the only required method, however.