Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add SSR to Hilla FAQ #3390

Merged
merged 1 commit into from
May 30, 2024
Merged

docs: add SSR to Hilla FAQ #3390

merged 1 commit into from
May 30, 2024

Conversation

landsman
Copy link

Resolving: #3385

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@landsman landsman changed the title add SSR to Hilla FAQ docs: add SSR to Hilla FAQ Apr 25, 2024
@landsman
Copy link
Author

I am not able to see what goes wrong on AWS, can someone check it please?
cc @jouni, @tomivirkki

Btw: It would be good to have build in GitHub Actions for these situations to let me handle it. Then send artifacts to AWS.

@tomivirkki tomivirkki requested a review from platosha May 15, 2024 07:54
@platosha platosha merged commit 7f0df5e into vaadin:hilla May 30, 2024
1 of 2 checks passed
@jouni
Copy link
Member

jouni commented May 30, 2024

The preview builds are useless at the moment, they don't work for any PRs. And only our IT department has access to that AWS build, to check why they fail.

@landsman, thanks for the suggestion, about doing the build with GH Actions instead. I assume Java and Maven are no problem, and we could run the build here. I’ll try to get that running eventually.

@landsman landsman deleted the patch-1 branch May 30, 2024 11:45
@landsman
Copy link
Author

@jouni thanks, it is actually even free for OSS project I think. Let me know if I can help with that - I did many github actions workflows similar to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants