Add better description how header title and content slots are aligned #4302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI Language ReviewThe only change made in the "When there is title text or element set via API, like in the example below, the content slot is automatically right aligned, otherwise it is left aligned." This new addition clarifies the alignment behavior of the content slot in the dialog header when a title is set via the API. No issues require improvement based on this modification. |
rolfsmeds
requested changes
May 23, 2025
| @@ -63,6 +63,8 @@ The Dialog component has static header and footer areas, and a scrolling content | |||
|
|
|||
| The header contains an optional title element, and a slot next to it for custom header content, such as a close button. | |||
|
|
|||
| When there is title text or element set via API, like in the example below, the content slot is automatically right aligned, otherwise it is left aligned. | |||
There was a problem hiding this comment.
Suggested change
| When there is title text or element set via API, like in the example below, the content slot is automatically right aligned, otherwise it is left aligned. | |
| If the dialog has a title (set via text or custom element), the header content slot is right-aligned. If no title is present, the header content slot is left-aligned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.