Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!(DatePicker): use unparsable-change instead of validated event #5572

Merged
merged 5 commits into from
Oct 18, 2023
Merged

fix!(DatePicker): use unparsable-change instead of validated event #5572

merged 5 commits into from
Oct 18, 2023

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Oct 12, 2023 •
edited
Loading

Description

The PR refactors DatePicker to make it trigger validation on unparsable-change event instead of the validated event.

Depends on

Warning
It's a behavior altering change because it removes validation on blur.

Part of #5537

Type of change

  • Bugfix

@vursen vursen changed the title fix!(DatePicker): replace validated with unparsable-change [WIP] fix!(DatePicker): replace validated with unparsable-change Oct 12, 2023
@vursen vursen force-pushed the feat/date-picker/unparsable-change branch from 652991a to 8d8d428 Compare October 13, 2023 07:16
@vursen vursen force-pushed the test/add-validation-counter branch from 2ccdf7a to e81dc49 Compare October 13, 2023 08:36
@vursen vursen changed the title [WIP] fix!(DatePicker): replace validated with unparsable-change fix!(DatePicker): replace validated with unparsable-change Oct 13, 2023
@vursen vursen force-pushed the feat/date-picker/unparsable-change branch from 8d8d428 to 2a8eac9 Compare October 13, 2023 08:44
Base automatically changed from test/add-validation-counter to main October 13, 2023 09:21
@vursen vursen force-pushed the feat/date-picker/unparsable-change branch from 73539fe to 81a9805 Compare October 13, 2023 10:34
@vursen vursen changed the title fix!(DatePicker): replace validated with unparsable-change fix!(DatePicker): use unparsable-change instead of validated event Oct 13, 2023
@vursen vursen changed the title fix!(DatePicker): use unparsable-change instead of validated event fix!(DatePicker): use unparsable-change instead of validated Oct 13, 2023
@vursen vursen changed the title fix!(DatePicker): use unparsable-change instead of validated fix!(DatePicker): use unparsable-change instead of validated event Oct 13, 2023
@vursen vursen force-pushed the feat/date-picker/unparsable-change branch from 70b8981 to a3d8960 Compare October 17, 2023 09:12
@vursen vursen marked this pull request as ready for review October 17, 2023 09:36
@vursen vursen force-pushed the feat/date-picker/unparsable-change branch from a3d8960 to bb3a427 Compare October 17, 2023 10:52
@vursen vursen force-pushed the feat/date-picker/unparsable-change branch from bb3a427 to 8d0edbe Compare October 18, 2023 08:48
@vursen vursen enabled auto-merge (squash) October 18, 2023 12:02
@vursen vursen merged commit 54c8e94 into main Oct 18, 2023
@vursen vursen deleted the feat/date-picker/unparsable-change branch October 18, 2023 12:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

@yuriy-fix yuriy-fix Awaiting requested review from yuriy-fix

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.3.0 Released with Vaadin 24.3.0.alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vursen @vaadin-bot @tomivirkki