refactor: replace setStackThreshold with setOverlayMode #7419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...yout-flow/src/main/java/com/vaadin/flow/component/masterdetaillayout/MasterDetailLayout.java
Outdated
Show resolved
Hide resolved
web-padawan
force-pushed
the
feat/mdl-overlay-mode
branch
from
0406b3b to
03219ca
Compare
web-padawan
force-pushed
the
feat/mdl-overlay-mode
branch
from
03219ca to
06545cc
Compare
sissbruecker
approved these changes
May 12, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to vaadin/web-components#9048
Based on vaadin/web-components#9052
Note: the
drawerwording is based on the internal discussion to have a cleaner distinction, so we technically consider bothdrawerandstackas two different types of the overlay mode. I'll also create a WC PR to usedrawerattribute for styling.Type of change