Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change line length to a more modern 120 #20169

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Oct 7, 2024

No description provided.

Copy link

github-actions bot commented Oct 7, 2024

Test Results

1 141 files  ± 0  1 141 suites  ±0   1h 16m 27s ⏱️ + 6m 31s
7 442 tests ± 0  7 392 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 802 runs   - 10  7 742 ✅  - 10  60 💤 ±0  0 ❌ ±0 

Results for commit 7545b25. ± Comparison against base commit f2dff39.

♻️ This comment has been updated with latest results.

@knoobie
Copy link
Contributor

knoobie commented Oct 7, 2024

Welcome in 2024! 🥳

Edit: might be good to also check this out once this is merged to preserve history https://github.com/orgs/community/discussions/5033

@caalador
Copy link
Contributor

caalador commented Oct 8, 2024

Will this lead to updating the line length for other alive versions also so that cherry picking works (has a better change to work) automatically?

@Artur-
Copy link
Member Author

Artur- commented Oct 8, 2024

It might work by happenstance. Otherwise #20164 and this + #20160 + #20185 should be backported to all relevant versions

Copy link

sonarcloud bot commented Oct 9, 2024

@mshabarov mshabarov marked this pull request as draft October 18, 2024 08:59
@mshabarov
Copy link
Contributor

Moved this to a draft as the discussion is ongoing about should we switch to longer lines or not.

@Artur-
Copy link
Member Author

Artur- commented Oct 20, 2024

Moved this to a draft as the discussion is ongoing about should we switch to longer lines or not.

Where is this discussion ongoing and what on earth are the arguments against it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants