Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test ordering #20466

Merged
merged 3 commits into from
Nov 14, 2024
Merged

test: fix test ordering #20466

merged 3 commits into from
Nov 14, 2024

Conversation

mcollovati
Copy link
Collaborator

Flow test suite contains some modules that define multiple pom files in the same folder. When executing Maven with -pl option pointing to such a folder, Maven will pick by default the pom file that is placed as the first in the parent pom's modules section.
This causes some poms to be executed twice and others to not be executed at all.
This change fixes ordering of modules, to ensure all are execute in validation workflow.

Flow test suite contains some modules that define multiple pom files in the
same folder. When executing Maven with -pl option pointing to such a folder,
Maven will pick by default the pom file that is placed as the first in the
parent pom's modules section.
This causes some poms to be executed twice and others to not be executed
at all.
This change fixes ordering of modules, to ensure all are execute in validation
workflow.
Copy link

github-actions bot commented Nov 13, 2024

Test Results

1 156 files  +10  1 156 suites  +10   1h 41m 22s ⏱️ + 7m 49s
7 498 tests + 9  7 445 ✅ + 6  53 💤 +3  0 ❌ ±0 
7 876 runs  +17  7 813 ✅ +14  63 💤 +3  0 ❌ ±0 

Results for commit 1b5717f. ± Comparison against base commit 05f0377.

This pull request skips 2 tests.
com.vaadin.flow.uitest.multimodule.ui.FrontendLiveReloadIT ‑ modifyMetaInfFrontendFile[any_Chrome_]
com.vaadin.flow.uitest.multimodule.ui.FrontendLiveReloadIT ‑ modifyMetaInfResourcesFrontendFile[any_Chrome_]

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Nov 13, 2024

mcollovati added a commit that referenced this pull request Nov 14, 2024
@mcollovati mcollovati merged commit 755a52c into main Nov 14, 2024
26 checks passed
@mcollovati mcollovati deleted the test/fix-matrix branch November 14, 2024 08:41
ZheSun88 pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants