Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use project .npmrc for tests #3089

Merged
merged 3 commits into from
Dec 30, 2024
Merged

test: Use project .npmrc for tests #3089

merged 3 commits into from
Dec 30, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Dec 28, 2024

Makes it possible to use a custom registry for dependency testing

Makes it possible to use a custom registry for dependency testing
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (242f830) to head (91de092).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3089   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          85       85           
  Lines        3164     3164           
  Branches      775      775           
=======================================
  Hits         2929     2929           
  Misses        183      183           
  Partials       52       52           
Flag Coverage Δ
unittests 92.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Artur- Artur- enabled auto-merge (squash) December 30, 2024 10:41
@Artur- Artur- merged commit 5719651 into main Dec 30, 2024
15 checks passed
@Artur- Artur- deleted the test-npmrc branch December 30, 2024 11:02
@vaadin-bot
Copy link
Collaborator

Hi @Artur- and @Artur-, when i performed cherry-pick to this commit to 24.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 5719651
error: could not apply 5719651... test: Use project .npmrc for tests (#3089)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants