fix: use dependsOn to force bean dependency
#3098
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3098 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 85 85
Lines 3164 3164
Branches 775 775
=======================================
Hits 2929 2929
Misses 183 183
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cromoteca
changed the title
dependsOn to force bean dependencydependsOn to force bean dependency
| @@ -154,6 +155,7 @@ private static ObjectMapper createDefaultEndpointMapper( | |||
| * @return the endpoint invoker | |||
| */ | |||
| @Bean | |||
| @DependsOn("hillaEndpointObjectMapper") | |||
There was a problem hiding this comment.
This ensures that the bean named ”hillaEndpointObjectMapper” is created before this bean, right? But what ensures that that particular mapper is used here and not some other ObjectMapper in the project?
There was a problem hiding this comment.
Should the same qualifier be used here
?There was a problem hiding this comment.
is the whole DependsOn now unnecessary, as it requires the specific Hilla object mapper?
…on-order-of-EndpointObjectMapper-and-endpointInvoker
|
Fixes #3092