fix(checkbox): add missing styles for hidden attribute (#137)

vaadin · Dec 18, 2018 · 4267426 · 4267426
1 parent c6a237d
commit 4267426
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/vaadin-checkbox.html b/src/vaadin-checkbox.html
@@ -17,6 +17,10 @@
         display: inline-block;
       }
 
+      :host([hidden]) {
+        display: none !important;
+      }
+
       label {
         display: inline-flex;
         align-items: baseline;

diff --git a/test/vaadin-checkbox_test.html b/test/vaadin-checkbox_test.html
@@ -105,6 +105,11 @@
         expect(vaadinCheckbox.name).to.eq('test-checkbox');
       });
 
+      it('should have display: none when hidden', () => {
+        vaadinCheckbox.setAttribute('hidden', '');
+        expect(getComputedStyle(vaadinCheckbox).display).to.equal('none');
+      });
+
       it('should toggle on host click', () => {
         vaadinCheckbox.click();