fix(checkbox): set focusElement to input to avoid firefox issue (#139)

vaadin · Jan 10, 2019 · bcbd99b · bcbd99b
1 parent 319a0a0
commit bcbd99b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/vaadin-checkbox.html b/src/vaadin-checkbox.html
@@ -266,8 +266,9 @@
           });
         }
 
+        /** @protected */
         get focusElement() {
-          return this.shadowRoot.querySelector('label');
+          return this.shadowRoot.querySelector('input');
         }
 
         /**

diff --git a/test/vaadin-checkbox_test.html b/test/vaadin-checkbox_test.html
@@ -85,6 +85,10 @@
         expect(children[2].outerHTML).to.be.equal('<i>Checkbox</i>');
       });
 
+      it('should have input as focusElement', () => {
+        expect(vaadinCheckbox.focusElement).to.be.eql(nativeCheckbox);
+      });
+
       it('can be disabled imperatively', () => {
         vaadinCheckbox.disabled = true;
         expect(nativeCheckbox.hasAttribute('disabled')).to.be.eql(true);