prefer updateComplete over nextFrame

vaadin · Dec 19, 2024 · 8801b9c · 8801b9c
1 parent f2d2cb0
commit 8801b9c
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/packages/dashboard/test/dashboard-keyboard.test.ts b/packages/dashboard/test/dashboard-keyboard.test.ts
@@ -23,6 +23,7 @@ import {
   setMinimumColumnWidth,
   setMinimumRowHeight,
   setSpacing,
+  updateComplete,
 } from './helpers.js';
 
 type TestDashboardItem = DashboardItem & { id: number };
@@ -209,7 +210,7 @@ describe('dashboard - keyboard interaction', () => {
 
     it('should move the widget backwards on arrow up', async () => {
       await sendKeys({ press: 'ArrowDown' });
-      await nextFrame();
+      await updateComplete(dashboard);
       await sendKeys({ press: 'ArrowUp' });
       expect(dashboard.items).to.eql([{ id: 0 }, { id: 1 }, { items: [{ id: 2 }, { id: 3 }] }]);
     });
@@ -246,7 +247,7 @@ describe('dashboard - keyboard interaction', () => {
       setMinimumRowHeight(dashboard, 100);
       await sendKeys({ down: 'Shift' });
       await sendKeys({ press: 'ArrowDown' });
-      await nextFrame();
+      await updateComplete(dashboard);
       await sendKeys({ press: 'ArrowUp' });
       await sendKeys({ up: 'Shift' });
       expect((dashboard.items[0] as DashboardItem).rowspan).to.equal(1);
@@ -365,7 +366,7 @@ describe('dashboard - keyboard interaction', () => {
 
       it('should move the widget backwards on arrow backwards', async () => {
         await sendKeys({ press: arrowForwards });
-        await nextFrame();
+        await updateComplete(dashboard);
         await sendKeys({ press: arrowBackwards });
         expect(dashboard.items).to.eql([{ id: 0 }, { id: 1 }, { items: [{ id: 2 }, { id: 3 }] }]);
       });
@@ -380,7 +381,7 @@ describe('dashboard - keyboard interaction', () => {
       it('should decrease the widget column span on shift + arrow backwards', async () => {
         await sendKeys({ down: 'Shift' });
         await sendKeys({ press: arrowForwards });
-        await nextFrame();
+        await updateComplete(dashboard);
         await sendKeys({ press: arrowBackwards });
         await sendKeys({ up: 'Shift' });
         expect((dashboard.items[0] as DashboardItem).colspan).to.equal(1);