fix: prevent selected item checkmark icon from flashing (#6635)

vaadin · Oct 12, 2023 · 986a777 · 986a777
1 parent e32a9c5
commit 986a777
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/context-menu/src/vaadin-contextmenu-items-mixin.js b/packages/context-menu/src/vaadin-contextmenu-items-mixin.js
@@ -214,10 +214,12 @@ export const ItemsMixin = (superClass) =>
         const { value } = event.detail;
         if (typeof value === 'number') {
           const item = listBox.items[value]._item;
+          // Reset selected before dispatching the event to prevent
+          // checkmark icon flashing before the overlay is closed.
+          listBox.selected = null;
           if (!item.children) {
             this.dispatchEvent(new CustomEvent('item-selected', { detail: { value: item } }));
           }
-          listBox.selected = null;
         }
       });