fix: add vaadin-button src import to unstyled confirm-dialog (#6540)

vaadin · Sep 26, 2023 · c42debf · c42debf
1 parent 8f6b33d
commit c42debf
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/packages/confirm-dialog/src/vaadin-confirm-dialog.js b/packages/confirm-dialog/src/vaadin-confirm-dialog.js
@@ -3,6 +3,7 @@
  * Copyright (c) 2018 - 2023 Vaadin Ltd.
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
+import '@vaadin/button/src/vaadin-button.js';
 import './vaadin-confirm-dialog-overlay.js';
 import { html, PolymerElement } from '@polymer/polymer/polymer-element.js';
 import { setAriaIDReference } from '@vaadin/a11y-base/src/aria-id-reference.js';

diff --git a/packages/confirm-dialog/test/dom/__snapshots__/confirm-dialog.test.snap.js b/packages/confirm-dialog/test/dom/__snapshots__/confirm-dialog.test.snap.js
@@ -22,20 +22,27 @@ snapshots["vaadin-confirm-dialog overlay"] =
   </div>
   <vaadin-button
     hidden=""
+    role="button"
     slot="cancel-button"
+    tabindex="0"
     theme="tertiary"
   >
     Cancel
   </vaadin-button>
   <vaadin-button
+    focused=""
+    role="button"
     slot="confirm-button"
+    tabindex="0"
     theme="primary"
   >
     Confirm
   </vaadin-button>
   <vaadin-button
     hidden=""
+    role="button"
     slot="reject-button"
+    tabindex="0"
     theme="error tertiary"
   >
     Reject
@@ -66,20 +73,27 @@ snapshots["vaadin-confirm-dialog overlay theme"] =
   </div>
   <vaadin-button
     hidden=""
+    role="button"
     slot="cancel-button"
+    tabindex="0"
     theme="tertiary"
   >
     Cancel
   </vaadin-button>
   <vaadin-button
+    focused=""
+    role="button"
     slot="confirm-button"
+    tabindex="0"
     theme="primary"
   >
     Confirm
   </vaadin-button>
   <vaadin-button
     hidden=""
+    role="button"
     slot="reject-button"
+    tabindex="0"
     theme="error tertiary"
   >
     Reject
@@ -110,20 +124,27 @@ snapshots["vaadin-confirm-dialog overlay class"] =
   </div>
   <vaadin-button
     hidden=""
+    role="button"
     slot="cancel-button"
+    tabindex="0"
     theme="tertiary"
   >
     Cancel
   </vaadin-button>
   <vaadin-button
+    focused=""
+    role="button"
     slot="confirm-button"
+    tabindex="0"
     theme="primary"
   >
     Confirm
   </vaadin-button>
   <vaadin-button
     hidden=""
+    role="button"
     slot="reject-button"
+    tabindex="0"
     theme="error tertiary"
   >
     Reject