fix: restore icon size workaround for Safari 26 #10296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Oct 6, 2025
web-padawan
reviewed
Oct 14, 2025
web-padawan
reviewed
Oct 14, 2025
Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
changed the title
web-padawan
reviewed
Oct 14, 2025
web-padawan
reviewed
Oct 14, 2025
|
web-padawan
approved these changes
Oct 14, 2025
DiegoCardoso
added a commit
that referenced
this pull request
Oct 14, 2025
Add the same check introduced in #10296 that adds the same testing element to a container with shadow root. It couldn't be cherry-picked since the changes have diverged in V25.
DiegoCardoso
added a commit
that referenced
this pull request
Oct 14, 2025
Add the same check introduced in #10296 that adds the same testing element to a container with shadow root. It couldn't be cherry-picked since the changes have diverged in V25.
web-padawan
pushed a commit
that referenced
this pull request
Oct 15, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts and adds a new check for the case where the
<vaadin-icon>is attached to an element with shadow root.Fixes vaadin/flow-components#8084
Type of change