feat: add has-drawer and has-navbar attributes #10311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
requested review from
jouni,
sissbruecker and
web-padawan
and removed request for
sissbruecker
jouni
reviewed
Oct 13, 2025
dev/aura/aura-view.css
Outdated
| :is(vaadin-app-layout[drawer-opened], vaadin-app-layout:has([slot='navbar'] vaadin-drawer-toggle)) | ||
| :is(.aura-view > header, .aura-view-header) | ||
| vaadin-drawer-toggle:not([theme~='permanent']), | ||
| vaadin-app-layout:is([drawer-opened], [has-navbar]) vaadin-drawer-toggle:not([theme~='permanent']), |
There was a problem hiding this comment.
This new selector doesn't cover the previous case. The second part of the first :is() selector checks if app layout has a drawer toggle within the navbar, and only then hides the drawer toggle in the view header. Now the drawer toggle in the view header is always hidden when there's a navbar, even without a drawer toggle.
There was a problem hiding this comment.
Good catch. It should be fixed now.
web-padawan
approved these changes
Oct 13, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
has-drawerandhas-navbarattributes toapp-layoutwhich are set automatically when their corresponding slots are present. As a result, this eliminates the need to use the:hasselector in Aura, which noticeably improves page rendering performance:(measurements are taken on
aura.htmlwith 4x CPU throttle)Type of change