Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert!: "feat: add dirty state to field components" #6436

Merged
merged 5 commits into from
Oct 4, 2023
Merged

revert!: "feat: add dirty state to field components" #6436

merged 5 commits into from
Oct 4, 2023

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Aug 31, 2023 •
edited
Loading

Description

The PR removes the dirty flag from the web components since we've decided to use a different approach to fix the original issue in Flow components.

Part of vaadin/flow-components#5712

Type of change

  • Revert

@vursen vursen marked this pull request as draft August 31, 2023 08:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen force-pushed the revert/dirty-flag branch from 201d019 to cd4cc33 Compare October 2, 2023 13:18
@vursen vursen marked this pull request as ready for review October 2, 2023 13:20
@vursen vursen requested review from web-padawan and tomivirkki and removed request for web-padawan October 3, 2023 05:45
@vursen vursen force-pushed the revert/dirty-flag branch from 4b854a8 to 7e98d2c Compare October 4, 2023 08:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vursen vursen merged commit e0274e8 into main Oct 4, 2023
9 checks passed
@vursen vursen deleted the revert/dirty-flag branch October 4, 2023 08:33
@vaadin-bot
Copy link
Collaborator

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.2, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick e0274e8
error: could not apply e0274e8... revert!: "feat: add dirty state to field components" (#6436)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

vursen added a commit that referenced this pull request Oct 4, 2023
@vursen
revert!: "feat: add dirty state to field components" (#6436)
defc4cf
@vursen vursen mentioned this pull request Oct 4, 2023
Merged
1 task
vursen added a commit that referenced this pull request Oct 4, 2023
@vursen
revert!: "feat: add dirty state to field components" (#6436) (#6592)
9cdce47
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
need to pick manually 24.2 Released with Vaadin 24.3.0 target/24.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vursen @vaadin-bot @tomivirkki @web-padawan