fix: make virtualizer with placeholders retry scroll to index #6588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
fix/virtualizer/placholders-scroll-to-index
branch
2 times, most recently
from
6c464b3 to
f1d3efd
Compare
tomivirkki
force-pushed
the
fix/virtualizer/placholders-scroll-to-index
branch
from
f1d3efd to
85c8afb
Compare
tomivirkki
force-pushed
the
fix/virtualizer/placholders-scroll-to-index
branch
from
85c8afb to
7aa6268
Compare
ugur-vaadin
reviewed
Oct 4, 2023
Co-authored-by: Ugur Saglam <[email protected]>
vursen
reviewed
Oct 4, 2023
vursen
approved these changes
Oct 4, 2023
vursen
approved these changes
Oct 4, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the virtualizer retry scrolling to an index on the next round of element updates in case there are placeholder items in the DOM after scrollToIndex.
This change is a prerequisite to finishing vaadin/flow-components#5037 without having to work around the issue in the connector.
Type of change
Bugfix