fix: validate on Enter only if there was an actual value commit #6590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
fix/date-picker/do-not-validate-when-no-change
branch
from
d4a013a to
012887e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Base automatically changed from
refactor/date-picker/internal-method-renamings
to
main
October 4, 2023 07:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR makes
date-pickervalidate on Enter only if there was an actual value commit 1 to align that with the native browser behavior.Part of vaadin/flow-components#5537
Type of change
Footnotes
Note, there can be parsable and unparsable value commits. ↩