Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make auto-width and text-align usable in custom slot (#6602) (CP: 24.2) #6620

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

DiegoCardoso
Copy link
Contributor

@DiegoCardoso DiegoCardoso commented Oct 9, 2023

Manual CP from #6602 to V24.2.

Adding the target labels here, since it's more likely that the vaadin-bot will be able to complete it.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DiegoCardoso DiegoCardoso changed the title chore: update change detection branch to 24.2 (#6517) (CP: 24.2) @DiegoCardoso fix: make auto-width and text-align usable in custom slot (#6602) (CP: 24.2) Oct 9, 2023
@DiegoCardoso DiegoCardoso changed the title @DiegoCardoso fix: make auto-width and text-align usable in custom slot (#6602) (CP: 24.2) fix: make auto-width and text-align usable in custom slot (#6602) (CP: 24.2) Oct 9, 2023
@DiegoCardoso DiegoCardoso merged commit a0fcc4a into 24.2 Oct 10, 2023
9 checks passed
@DiegoCardoso DiegoCardoso deleted the cp/grid/slotted-grid/24.2 branch October 10, 2023 06:36
@vaadin-bot
Copy link
Collaborator

Hi @DiegoCardoso and @DiegoCardoso, when i performed cherry-pick to this commit to 24.1, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a0fcc4a
error: could not apply a0fcc4a... fix: make auto-width and text-align usable in custom slot (#6602) (CP: 24.2) (#6620)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @DiegoCardoso and @DiegoCardoso, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a0fcc4a
error: could not apply a0fcc4a... fix: make auto-width and text-align usable in custom slot (#6602) (CP: 24.2) (#6620)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants