Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add className property for adding CSS classes to menu-bar items #6633

Merged
merged 4 commits into from
Oct 11, 2023
Merged

feat: add className property for adding CSS classes to menu-bar items #6633

merged 4 commits into from
Oct 11, 2023

Conversation

DiegoCardoso
Copy link
Contributor

Description

Add className property to define CSS class to menu-bar items and sub-items via the items array.

Part of #5342

Type of change

  • Bugfix
  • Feature

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DiegoCardoso DiegoCardoso merged commit 677d037 into main Oct 11, 2023
9 checks passed
@DiegoCardoso DiegoCardoso deleted the feat/menu-bar/class-names branch October 11, 2023 13:21
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki left review comments

@web-padawan web-padawan web-padawan approved these changes

Assignees
No one assigned
Labels
Released with Vaadin 24.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DiegoCardoso @vaadin-bot @tomivirkki @web-padawan