Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Lumo custom CSS properties to set focus-ring #6634

Merged
merged 2 commits into from
Oct 17, 2023
Merged

feat: add Lumo custom CSS properties to set focus-ring #6634

merged 2 commits into from
Oct 17, 2023

Conversation

web-padawan
Copy link
Member

Description

Part of #2954

Type of change

  • Feature

@web-padawan web-padawan force-pushed the feat/focus-ring-css-props branch 3 times, most recently from d2d04ac to aefcede Compare October 16, 2023 08:45
@web-padawan web-padawan marked this pull request as ready for review October 16, 2023 08:53
@web-padawan web-padawan force-pushed the feat/focus-ring-css-props branch from aefcede to 469de3a Compare October 16, 2023 08:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan requested a review from rolfsmeds October 17, 2023 07:27
rolfsmeds
rolfsmeds approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@rolfsmeds rolfsmeds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this now underscores how crazy it was to NOT have these definable through a property! :)

@web-padawan web-padawan merged commit fc54a1d into main Oct 17, 2023
9 checks passed
@web-padawan web-padawan deleted the feat/focus-ring-css-props branch October 17, 2023 12:55
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.alpha1 and is also targeting the upcoming stable 24.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfsmeds rolfsmeds rolfsmeds approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.3.0 Released with Vaadin 24.3.0.alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @vaadin-bot @rolfsmeds