test: extract keyboard interaction mode tests #7992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Oct 18, 2024
|
web-padawan
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Getting this locally when running test on MacOS. Also happens on main so not a blocker.
packages/grid/test/keyboard-interaction-mode-lit.test.js:
❌ keyboard interaction mode > should tab through the elements in order
AssertionError: expected 13 to equal 11
+ expected - actual
-13
+11
at n.<anonymous> (packages/grid/test/keyboard-interaction-mode.common.js:562:35)
packages/grid/test/keyboard-interaction-mode-polymer.test.js:
❌ keyboard interaction mode > should tab through the elements in order
AssertionError: expected 13 to equal 11
+ expected - actual
-13
+11
at n.<anonymous> (packages/grid/test/keyboard-interaction-mode.common.js:562:35)
web-padawan
approved these changes
Oct 18, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Serhii Kulykov <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Serhii Kulykov <[email protected]>
vursen
added a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Sergey Vinogradov <[email protected]> Co-authored-by: Serhii Kulykov <[email protected]>
vursen
added a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: Sergey Vinogradov <[email protected]> Co-authored-by: Serhii Kulykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
getFocusedRowIndexandgetFocusedCellIndexhelpers into the common grid helpers fileType of change