fix: resize only on direction of drag move #8222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ugur-vaadin
commented
Nov 25, 2024
| @@ -323,6 +349,99 @@ describe('dashboard - widget resizing', () => { | |||
| ]); | |||
| }); | |||
|
|
|||
| (isSafari ? it.skip : it)('should resize only when dragged in the same direction (top -> bottom)', async () => { | |||
There was a problem hiding this comment.
For some reason this test fails on Safari. When manually testing, it seems to work.
tomivirkki
approved these changes
Nov 26, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.beta3 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the flicker on drag resize by only allowing resize if the drag direction is the same with the resize direction.
Fixes #7950
Type of change
Checklist