Code

[feat] Card slots#8233

Code

Merged

web-padawan merged 35 commits intomainvaadin/web-components:mainfrom card-protovaadin/web-components:card-protoCopy head branch name to clipboardJan 20, 2025

+998-494

Commits

Commits on Jan 10, 2025

• vertical orientation works alright, horizontal has issues

  

  jouni

  authored and

  web-padawan

  committed
  03b759c

  Copy full SHA for 03b759c

• remove commented code

  

  jouni

  authored and

  web-padawan

  committed
  af7e9c4

  Copy full SHA for af7e9c4

• Update card.html

  

  jouni

  authored and

  web-padawan

  committed
  4b085d9

  Copy full SHA for 4b085d9

• Update card.html

  

  jouni

  authored and

  web-padawan

  committed
  476f73b

  Copy full SHA for 476f73b

• keep media as the first child

  

  jouni

  authored and

  web-padawan

  committed
  0a6dcd2

  Copy full SHA for 0a6dcd2

• experiment with custom properties (no horizontal version)

  

  jouni

  authored and

  web-padawan

  committed
  906c67e

  Copy full SHA for 906c67e

• robust prototype with slots and shadow parts

  

  jouni

  authored and

  web-padawan

  committed
  bf28c91

  Copy full SHA for bf28c91

• improve dev playground

  

  jouni

  authored and

  web-padawan

  committed
  d5b3bad

  Copy full SHA for d5b3bad

• switch cover-media <-> stretch-media variant names

  

  jouni

  authored and

  web-padawan

  committed
  7b0359b

  Copy full SHA for 7b0359b

• fix material theme

  

  jouni

  authored and

  web-padawan

  committed
  52103aa

  Copy full SHA for 52103aa

• fix: run mutation observer once when connected

  

  jouni

  authored and

  web-padawan

  committed
  a441654

  Copy full SHA for a441654

• fix a couple of sonarcloud issues

  

  jouni

  authored and

  web-padawan

  committed
  3ce3ebd

  Copy full SHA for 3ce3ebd

• update visual test for Lumo

  

  jouni

  authored and

  web-padawan

  committed
  809aea2

  Copy full SHA for 809aea2

• remove duplicate visual test

  

  jouni

  authored and

  web-padawan

  committed
  66b8b4b

  Copy full SHA for 66b8b4b

• update visual test for Material

  

  jouni

  authored and

  web-padawan

  committed
  53a81fa

  Copy full SHA for 53a81fa

• use Lumo-specific component imports in Lumo tests

  

  jouni

  authored and

  web-padawan

  committed
  ebf16f9

  Copy full SHA for ebf16f9

• fix CSS lint error

  

  jouni

  authored and

  web-padawan

  committed
  32ea420

  Copy full SHA for 32ea420

• remove TODOs

  Show description for 88ec3be
  

  jouni

  authored and

  web-padawan

  committed
  88ec3be

  Copy full SHA for 88ec3be

• First draft of JSDoc

  

  jouni

  authored and

  web-padawan

  committed
  c457bff

  Copy full SHA for c457bff

• prefix internal custom props with underscore

  

  jouni

  authored and

  web-padawan

  committed
  8f0f7f7

  Copy full SHA for 8f0f7f7

• refactor: use slotchange listener instead of MutationObserver

  

  jouni

  authored and

  web-padawan

  committed
  46a67f0

  Copy full SHA for 46a67f0

• test: update screenshots

  web-padawan

  committed
  97c0048

  Copy full SHA for 97c0048

• test: import badge-global in card visual test

  web-padawan

  committed
  28eb9d4

  Copy full SHA for 28eb9d4

• test: remove Lumo custom CSS properties from Material test

  web-padawan

  committed
  e6f28c1

  Copy full SHA for e6f28c1

• test: cleanup card visual test, use local image (#8369)

  web-padawan

  committed
  c97da29

  Copy full SHA for c97da29

• fix: restore styles for hidden attribute

  web-padawan

  committed
  e6307c9

  Copy full SHA for e6307c9

• docs: add protected JSDoc annotations

  web-padawan

  committed
  d7f7e8b

  Copy full SHA for d7f7e8b

• refactor: add box-sizing border-box to card styles

  web-padawan

  committed
  f43304f

  Copy full SHA for f43304f

• test: update visual test screenshots

  web-padawan

  committed
  8f4e7ec

  Copy full SHA for 8f4e7ec

• test: update screenshots

  web-padawan

  committed
  a93ebfd

  Copy full SHA for a93ebfd

Commits on Jan 17, 2025

• run prettier

  jouni

  committed
  6693674

  Copy full SHA for 6693674

• refactor: use attributes for styling in all browsers

  Show description for 5994bf0
  jouni

  committed
  5994bf0

  Copy full SHA for 5994bf0

• fix: remove unnecessary disconnectedcallback

  jouni

  committed
  7e06edb

  Copy full SHA for 7e06edb

• fix: cleanup custom attributes from dev page code example

  jouni

  committed
  fa76360

  Copy full SHA for fa76360

• refactor: add slotchange listener in createRenderRoot

  jouni

  committed
  4684b8d

  Copy full SHA for 4684b8d