fix: ignore target set while popover is detached until re-attached #8350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
Dec 16, 2024
sissbruecker
approved these changes
Dec 16, 2024
tomivirkki
approved these changes
Dec 16, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 16, 2024
…8350) (#8353) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Dec 16, 2024
…8350) (#8352) Co-authored-by: Serhii Kulykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#6953
Currently, target listeners are removed when popover is detached. However, we don't handle case when
targetproperty is set while detached - in this case, the target listeners will be still added. This PR fixes that by changing the observer logic to use_isConnectedproperty and take it into account when checking whether listeners should be added.Type of change