fix: teleport CRUD form to overlay if some buttons are not set #8372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tomivirkki
approved these changes
Dec 19, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 20, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 20, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 20, 2024
#8382) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Dec 20, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#6965
Updated the check before moving child nodes to allow teleporting header and form if some of buttons is not set.
This covers the case with
_noDefaultButtons(used by Flow counterpart) when usingsetVisible(false)which not only setshiddenattribute on the corresponding button, but also disallows setting properslotattribute on it.Type of change