fix: do not close select overlay when opened before attached #8402
+55
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favor of #8401 |
1 task
web-padawan
force-pushed
the
fix/select-pre-opened-observer
branch
from
a8bf032 to
bb2459d
Compare
web-padawan
force-pushed
the
fix/select-pre-opened-observer
branch
from
bb2459d to
b0f72d7
Compare
vursen
approved these changes
Dec 27, 2024
vursen
reviewed
Dec 27, 2024
|
vursen
approved these changes
Dec 27, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 27, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 27, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 27, 2024
…8403) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Dec 27, 2024
…8404) Co-authored-by: Serhii Kulykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8398
Changed the observer to depend on
_overlayElement(also, updated the order of setting references inready()as the observer also uses_inputContainerinternally - didn't include both to avoid triggering it multiple times unnecessarily).Type of change
Note
I didn't remove resetting
openedtofalseas that could be considered a behavior altering change, and I added some missing tests that cover the relevant part of the observer forreadonlyanddisabledtest suites.