fix: do not clear on Esc with clear button visible when readonly #8455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
reviewed
Jan 8, 2025
Co-authored-by: Sascha Ißbrücker <[email protected]>
|
sissbruecker
approved these changes
Jan 8, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
web-padawan
added a commit
that referenced
this pull request
Jan 8, 2025
…) (#8458) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Jan 8, 2025
…) (#8459) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Jan 9, 2025
…) (#8460) Co-authored-by: Serhii Kulykov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.7.0.alpha3 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8448
readonlyproperty before clearing value on EscComboBoxMixinlistener to remove duplication and only check forreadonlyonceType of change
Note
Ideally this change would require moving
readonlyproperty toClearButtonMixinsince it's now used there.However we already have some problems with mixins structure since e.g.
ComboBoxMixinandDatePickerMixintechnically useclearButtonVisiblewhile not extendingClearButtonMixin. So maybe we can keep it as is for now.