Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move app-layout styles import to avoid warning with Lit #8456

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

web-padawan
Copy link
Member

Description

This fixes the following warning introduced in #8387:

packages/app-layout/test/app-layout-lit.test.js:

 🚧 Browser logs:
      The custom element definition for "vaadin-app-layout" was finalized before a style module was registered. Ideally, import component specific style modules before importing the corresponding custom element. This warning can be suppressed by setting "window.Vaadin.suppressPostFinalizeStylesWarning = true".

Type of change

  • Test

@web-padawan web-padawan requested a review from vursen January 8, 2025 13:42
Copy link

sonarqubecloud bot commented Jan 8, 2025

@web-padawan web-padawan merged commit 0292676 into main Jan 8, 2025
9 checks passed
@web-padawan web-padawan deleted the test/app-layout-styles branch January 8, 2025 13:50
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha3 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants