fix: do not stop ignored dragleave events in grid #8500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tomivirkki
changed the title
web-padawan
approved these changes
Jan 13, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
web-padawan
pushed a commit
that referenced
this pull request
Jan 13, 2025
Co-authored-by: Tomi Virkki <[email protected]>
web-padawan
pushed a commit
that referenced
this pull request
Jan 13, 2025
Co-authored-by: Tomi Virkki <[email protected]>
|
@tomivirkki could we also pick this to 24.4 ? |
tomivirkki
added a commit
that referenced
this pull request
Jan 13, 2025
|
@mshabarov cherry-picked here #8503 |
web-padawan
pushed a commit
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grid currently stops the propagation of all native "dragleave" events which causes the issue. The propagation of "dragleave" event should only be stopped if the grid has a
dropMode, in which case corresponding "dragover" and "dragenter" events are also processed by the grid dnd logicFixes #8476
Type of change