wip

vacp2p · Jul 22, 2024 · 244c307 · 244c307
1 parent bcc002a
commit 244c307
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 15 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -20,16 +20,12 @@ jobs:
         platform:
           - os: linux
             cpu: amd64
-            shell: bash
           - os: linux
             cpu: i386
-            shell: bash
           - os: macos
             cpu: amd64
-            shell: bash
           - os: windows
             cpu: amd64
-            shell: msys2 {0}
         nim: 
           - branch: version-1-6
             memory_management: refc

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -1,7 +1,7 @@
 name: Coverage
 
 on:
-  # On push to common branches, this computes the coverage PRs will compared against
+  # On push to common branches, this computes the coverage that PRs will use for diff
   push:
     branches:
       - master
@@ -41,7 +41,7 @@ jobs:
         if: ${{ steps.deps-cache.outputs.cache-hit != 'true' }}
         run: |
           nimble install_pinned
-      
+
       - name: Setup coverage
         run: |
           sudo apt-get update
@@ -54,7 +54,7 @@ jobs:
           nimble testnative
           nimble testpubsub
           nimble testfilter
-      
+
       - name: Run coverage
         run: |
           find nimcache -name *.c -delete
@@ -63,7 +63,7 @@ jobs:
           ls `pwd`/libp2p/{*,**/*}.nim
           lcov --extract coverage/coverage.info  `pwd`/libp2p/{*,**/*}.nim --output-file coverage/coverage.f.info
           genhtml coverage/coverage.f.info --output-directory coverage/output
-      
+
       - name: Upload coverage to codecov
         run: |
           bash <(curl -s https://codecov.io/bash) -f coverage/coverage.f.info || echo "Codecov did not collect coverage reports"
diff --git a/.github/workflows/dependencies.yml b/.github/workflows/dependencies.yml
@@ -8,17 +8,19 @@ on:
 
 jobs:
   update_version:
-    # Pushes new refs to interested external repositories, so they can do early testing against them.
+    # Pushes new refs to interested external repositories, so they can do early testing against libp2p's newer versions
     runs-on: ubuntu-latest
     name: Update libp2p's version for ${{ matrix.target.repository }}:${{ matrix.target.ref }}
     strategy:
       fail-fast: false
       matrix:
-        target: [
-          { repository: status-im/nimbus-eth2, ref: unstable },
-          { repository: waku-org/nwaku, ref: master },
-          { repository: codex-storage/nim-codex, ref: master }
-        ]
+        target:
+          - repository: status-im/nimbus-eth2
+            ref: unstable
+          - repository: waku-org/nwaku
+            ref: master
+          - repository: codex-storage/nim-codex
+            ref: master
     steps:
       - name: Clone target repository
         uses: actions/checkout@v4
@@ -27,7 +29,7 @@ jobs:
           ref: ${{ matrix.target.ref}}
           path: nbc
           fetch-depth: 0
-          token:  ${{ secrets.ACTIONS_GITHUB_TOKEN }}
+          token: ${{ secrets.ACTIONS_GITHUB_TOKEN }}
 
       - name: Checkout this ref in target repository
         run: |