Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding onValidated observer #1128

Merged
merged 10 commits into from
Aug 1, 2024
+73 −2
Merged

feat: adding onValidated observer #1128

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e83fe79
chore: adding onRecvAndValidated observers
gabrielmer Jul 16, 2024
096026e
add extra nil check and modify test
gabrielmer Jul 19, 2024
363dfdd
fix test
gabrielmer Jul 19, 2024
4fc5918
renaming observer to onValidated
gabrielmer Jul 31, 2024
29c5f96
resetting old test and creating a new observers one
gabrielmer Jul 31, 2024
bb0d0fb
fix compilation error
gabrielmer Jul 31, 2024
b6b1782
fixing test
gabrielmer Jul 31, 2024
82f7927
rename and delete unnecessary if condition
gabrielmer Jul 31, 2024
ad548cf
discarding handler
gabrielmer Aug 1, 2024
00fb971
removing nodesFut
gabrielmer Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test
@gabrielmer
gabrielmer committed Aug 1, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 363dfddf305a6ebe79366b3cc64e086bd3daef14
9 changes: 6 additions & 3 deletions tests/pubsub/testgossipsub.nim
View file
Original file line number Diff line number Diff line change
@@ -357,17 +357,20 @@ suite "GossipSub":
let
obs1 = PubSubObserver(
onRecv: proc(peer: PubSubPeer, msgs: var RPCMsg) =
inc observed,
onRecvAndValidated: proc(peer: PubSubPeer, msg: Message, msgId: MessageId) =
inc observed
)
obs2 = PubSubObserver(
onRecvAndValidated: proc(peer: PubSubPeer, msg: Message, msgId: MessageId) =
inc observed
)
obs3 = PubSubObserver(
onSend: proc(peer: PubSubPeer, msgs: var RPCMsg) =
inc observed
)

nodes[1].addObserver(obs1)
nodes[0].addObserver(obs2)
nodes[1].addObserver(obs2)
nodes[0].addObserver(obs3)

tryPublish await nodes[0].publish("foobar", "Hello!".toBytes()), 1