Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Fix dependency solver flag not being parsed. #1189

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(ci): Fix dependency solver flag not being parsed. #1189

wants to merge 3 commits into from

Conversation

AlejandroCabeza
Copy link
Collaborator

No description provided.

@AlejandroCabeza AlejandroCabeza enabled auto-merge (squash) September 6, 2024 14:46
lchenut
lchenut approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@lchenut lchenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

diegomrsantos
diegomrsantos suggested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@diegomrsantos diegomrsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mistake in the PR. The pull_request trigger hasn't been removed. Moreover, this PR needs to make sure the changes are working as expected.

@AlejandroCabeza
Copy link
Collaborator Author

There's a mistake in the PR. The pull_request trigger hasn't been removed. Moreover, this PR needs to make sure the changes are working as expected.

I don't think I follow. The pull_request trigger hasn't been removed because it remains as proof that it's indeed working as expected. Could you elaborate what would you need me to do next?

@AlejandroCabeza AlejandroCabeza self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomrsantos diegomrsantos diegomrsantos requested changes

@lchenut lchenut lchenut approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@AlejandroCabeza AlejandroCabeza

Labels
None yet
Projects
nim-libp2p
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlejandroCabeza @diegomrsantos @lchenut