Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(test): handle IHAVE / IWANT tests #1202

Merged
merged 1 commit into from
Oct 31, 2024
Merged

docs(test): handle IHAVE / IWANT tests #1202

merged 1 commit into from
Oct 31, 2024

Conversation

AlejandroCabeza
Copy link
Collaborator

Add documentation as requested.

@AlejandroCabeza AlejandroCabeza self-assigned this Sep 27, 2024
@AlejandroCabeza AlejandroCabeza requested review from AYAHASSAN287, lchenut and diegomrsantos and removed request for AYAHASSAN287 September 30, 2024 10:09
lchenut
lchenut approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@lchenut lchenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlejandroCabeza AlejandroCabeza added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit 294d063 Oct 31, 2024
9 of 14 checks passed
@AlejandroCabeza AlejandroCabeza deleted the docs/ihave-iwant-tests branch October 31, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchenut lchenut lchenut approved these changes

@diegomrsantos diegomrsantos Awaiting requested review from diegomrsantos

Assignees

@AlejandroCabeza AlejandroCabeza

Labels
None yet
Projects
nim-libp2p
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlejandroCabeza @lchenut