-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tls-certificate): generate and parse libp2p tls certificate #1209
Conversation
for i in 0 ..< LIBP2P_EXT_OID_DER.len: | ||
if ptrInc(oid.p, i.uint)[] != LIBP2P_EXT_OID_DER[i]: | ||
return MBEDTLS_ERR_OID_NOT_FOUND # Extension not handled by this callback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use nimCmpMem
? Not sure if importing just for that is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is it defined?
e2e6b6b
to
f87cc67
Compare
The certificates that was being generated was considered invalid due to not having a serial number. This was fixed in last commit and now the certificates are readable in openssl:
cc: @kaiserd |
Commits must follow the Conventional Commits specification
|
903de59
to
74a1ea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; minor comment
d6c9286
to
c1294d4
Compare
This PR implements the certificate generation and parsing for https://github.com/libp2p/specs/blob/master/tls/tls.md.