Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:missing raises pragma for one of RendezVous.new #1222

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

NagyZoltanPeter
Copy link
Contributor

Small issue arose in nwaku while bumping to v1.7 of nim-libp2p.
There is a missing pragma preventing compilation while using RendezVous.new(switch).
Seems only nwaku is using that version, hence it overlooked.

Issue: #1221

@NagyZoltanPeter NagyZoltanPeter self-assigned this Nov 8, 2024
Copy link
Collaborator

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@kaiserd kaiserd added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 8, 2024
@kaiserd kaiserd added this pull request to the merge queue Nov 8, 2024
@kaiserd kaiserd removed this pull request from the merge queue due to the queue being cleared Nov 8, 2024
@kaiserd kaiserd merged commit 8855bce into master Nov 8, 2024
14 checks passed
@kaiserd kaiserd deleted the fix-missing-raiser-pragma-in-rendezvous branch November 8, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

2 participants