Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10/WAKU2: Update #125

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

10/WAKU2: Update #125

wants to merge 6 commits into from

Conversation

jimstir
Copy link
Collaborator

@jimstir jimstir commented Feb 6, 2025

Updates include changing links, removing deprecated specs, and adding updated specs.

@jimstir jimstir requested a review from jm-clius February 13, 2025 10:56
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, as these changes certainly improve the spec. Main open question is whether (or how) we can stop using the slightly clumsy "Waku v2" everywhere. I also think Research should add this spec to its backlog for a thorough review, as the state of the art looks very different now from when this spec was first compiled. Thanks!

@@ -14,37 +14,37 @@ contributors:

## Abstract

Waku v2 is family of modular peer-to-peer protocols for secure communication.
Waku v2 is a family of modular peer-to-peer protocols for secure communication.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, I realise now I forgot to comment about this while reviewing the WAKU2-MESSAGE spec, but we've generally stopped referring to "Waku v2" and simply use "Waku". The "v2" seems to confuse people, as v1 (now usually just "legacy Waku") is implemented nowhere, difficult to find specifications for and not actively developed. We do want to acknowledge though that this spec introduced a newly designed Waku stack. Perhaps it's possible to drop the "Waku v2" but add a single comment at the top to explain that this suite of protocols were previously referred to as "Waku v2" in order to distinguish it from the obsolete legacy Waku protocol stack?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this affect all Waku RFCs and RFC IDs? Also may need consensus from the other contributors named in this spec if that is the case. I think the only conflict may be with the stable spec 11/WAKU2-RELAY which only mention Waku v2 in the name within the header (stable specs can not be updated).
The way 11/WAKU2-RELAY is written may be an alternative approach where Waku is used throughout the spec, but v2 is only mentioned in the name within the header. This would still require an update of other spec but doable. @jm-clius


### Request/Reply domain
### Request/Reply Domain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've since opted for "Request/Response" instead of .../Reply

@jimstir jimstir mentioned this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants